Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hci: improved implementation and fixes #231

Merged
merged 3 commits into from
Jan 24, 2024
Merged

hci: improved implementation and fixes #231

merged 3 commits into from
Jan 24, 2024

Conversation

deadprogram
Copy link
Member

@deadprogram deadprogram commented Jan 22, 2024

This PR updates the hci implementation aka ninafw with several improvements and fixes including:

  • check for polling buffing overflow
  • allow for multiple connections as a central
  • add l2cap signaling
  • implement evtNumCompPkts to count in-flight packets
  • correct implementation for WriteWithoutReponse
  • speed up time waiting for hardware
  • corrections to MTU exchange

@deadprogram deadprogram changed the title hci: l2cap implementation and some fixes hci: improved implementation and fixes Jan 22, 2024
@deadprogram
Copy link
Member Author

This PR collects the results of my weekend adventures.

After these fixes, I am able to get my bluetooth drone to takeoff. 🚁

adapter_ninafw.go Outdated Show resolved Hide resolved
l2cap_hci.go Outdated Show resolved Hide resolved
@deadprogram deadprogram force-pushed the hci-l2cap-and-fixes branch 2 times, most recently from f04fd81 to 4487499 Compare January 23, 2024 10:28
- add l2cap signaling support
- implement evtNumCompPkts to count in-flight packets
- correct implementation for WriteWithoutReponse
- speed up time waiting for hardware
- corrections to MTU exchange

Signed-off-by: deadprogram <[email protected]>
@bgould
Copy link
Member

bgould commented Jan 24, 2024

LGTM, merging

@bgould bgould merged commit 07a9e1d into dev Jan 24, 2024
5 checks passed
@bgould bgould deleted the hci-l2cap-and-fixes branch January 24, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants